Fix CPE generation for k8s python client #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Luhring <[email protected]>
|
This CI failure seems unrelated 🤔 --- FAIL: TestHandler_handleAttestationStarted (0.00s)
--- FAIL: TestHandler_handleAttestationStarted/attesting_in_progress (0.00s)
--- FAIL: TestHandler_handleAttestationStarted/attesting_in_progress/log (0.00s)
handle_attestation_test.go:122: Message: ui.attestLogFrameTickMsg {Time:2023-07-07 16:44:22.114146643 +0000 UTC m=+0.013199686 Sequence:0 ID:2252984603}
handle_attestation_test.go:122: Message: tea.BatchMsg [0x637080]
handle_attestation_test.go:127:
handle_attestation_test.go:1[28](https://github.com/anchore/syft/actions/runs/5488646137/jobs/10001775887?pr=1921#step:9:29):
- Snapshot - 3
+ Received + 0
- ░░ contents
- ░░ of
- ░░ stuff! |
|
Could be related to this? |
spiffcs
approved these changes
Jul 10, 2023
* main: chore: update iterations to protect against race (anchore#1927) chore(deps): update bootstrap tools to latest versions (anchore#1922) fix: Don't use the actual redis or grpc CPEs for gems (anchore#1926)
spiffcs
added a commit
that referenced
this pull request
Jul 11, 2023
* main: feat: CLI flag for directory base (#1867) Fix CPE gen for k8s python client (#1921) chore: update iterations to protect against race (#1927) chore(deps): update bootstrap tools to latest versions (#1922) fix: Don't use the actual redis or grpc CPEs for gems (#1926) fix(install): return with right error code (#1915) Remove erroneous Java CPEs from generation (#1918) chore(deps): bump golang.org/x/net from 0.11.0 to 0.12.0 (#1916) Switch UI to bubbletea (#1888) fix: use filepath.EvalSymlinks if os.Readlink fails to evaluate the link (#1884) add file source digest support (#1914) chore(deps): update bootstrap tools to latest versions (#1908) chore(deps): bump golang.org/x/mod from 0.11.0 to 0.12.0 (#1912) chore(deps): bump golang.org/x/term from 0.9.0 to 0.10.0 (#1913) doc(readme): add installation section with scoop (#1909) Refactor source API (#1846) chore(deps): update bootstrap tools to latest versions (#1905)
This was referenced Jul 12, 2023
Merged
This was referenced Jul 28, 2023
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
Signed-off-by: Dan Luhring <[email protected]> Co-authored-by: Christopher Phillips <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was seeing the Python K8s client library getting the CPE
...:kubernetes:kubernetes:..., which is for Kubernetes itself.I've been looking through NVD, and I don't think there's actually a CPE assigned yet for the Python client, but they use
...:kubernetes:java:...for the Java client, so it seemed like a good move to avoid using thekubernetesproduct for the Python library (and assume that the product would most likely be something likepython).